fix: add container prop and improve flex/layout handling #4742
Conversation
|
@durandt could you please whether it fixes the issue? |
|
The mobile version of example app from this branch is ready! You can see it here. |
Sure @lukewalczak , I would be glad to help. I have only been working with RN for a year or so, what would be the best way to test your PR? Apply-patch? Or do you have the build artifacts somewhere? (I didn't find them in the PR build) (EDIT: I'll try cloning the repo, building with |
|
You can try to install it from the branch, by editing package.json: If you have cloned repo, you can also try use the yalc tool to link the package to the project |
|
Thank you very much @lukewalczak 🙏, that now works as intended with the provided patch. Wishing you a nice day 🌤️ |
Motivation
This PR improves the behavior of the
Surfacecomponent regarding flexbox layout and style inheritance, especially on iOS, and introduces a new internalcontainerprop for more explicit control.This prop allows internal components (like Button, Card, etc.) to explicitly specify whether the
Surfaceshould behave as a main layout container or as a simple wrapper.Related issue
#3652
#4632
Test plan
Tested against two mentioned issues: